PythonCharmers/python-future

Type not in (int, long) converted to not in (int, int)

Open

#265 创建于 2017年1月19日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)Python (1,172 star) (327 fork)batch import
0.19bughelp wantedtype-conversion

描述

Currently,

if type(time) not in (int, long): is converted to: if type(time) not in (int, int) (version 0.15.2)

This does not seem correct.

Following http://python3porting.com/differences.html I have instead changed this to:

if sys.version_info < (3,):
    integer_types = (int, long)
else:
    integer_types = (int,)

and then: if type(time) not in integer_types:

It would be excellent if this was built into futurize.

贡献者指南

技术栈
python
领域
backend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic PythonUnderstanding of Python 2/3 differences
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
The issue describes a bug where futurize incorrectly converts 'not in (int, long)' to 'not in (int, int)'. Investigate the source code in the futurize script, likely in the type conversion logic. Look for where 'long' is replaced and ensure the correct mapping to integer types. The maintainer proposed an alternative using sys.version info, which could be a guide for the fix. The issue is old and uncommented, so verify the current state of the codebase.