PyO3/pyo3

Seal traits inside `impl_` submodule

Open

#3,908 创建于 2024年2月27日

在 GitHub 查看
 (13 评论) (0 反应) (0 负责人)Rust (10,152 star) (668 fork)batch import
Good First Issue

描述

Off the back of https://github.com/PyO3/pyo3/pull/3897#discussion_r1504721475

Should we review the traits inside the impl_ submodule, check which ones can be sealed, and do that? It's a reasonable safety mechanism to prevent users from trying to implement those things.

贡献者指南

技术栈
rust
领域
backenddeveloper experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
active
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Knowledge of Rust's sealed trait patternFamiliarity with PyO3's `impl ` submodule
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
45
研究方向
Start by examining the `impl ` submodule in the pyo3 crate's source code. Review the discussion in PR #3897, especially the comment at the linked line, to understand which traits are candidates for sealing. Then, implement a private sealed trait marker (e.g., a hidden supertrait) and modify the trait definitions in the `impl ` submodule to require that marker. Ensure that the sealing does not break existing functionality and is backward compatible. The issue does not specify all traits to seal, so you may need to propose a list and get feedback from maintainers.