ProjectEvergreen/greenwood

<script> tags using optimization attributes have a space before the closing bracket of the opening tag

开放

#1,052 创建于 2023年2月5日

 (1 条评论) (0 个反应) (0 位负责人)JavaScript (15 个派生)auto 404
CLIenhancementgood first issue

仓库指标

星标
 (132 个星标)
PR 合并指标
 (平均合并 25天 20小时) (30 天内合并 29 个 PR)

描述

Type of Change

Enhancement / Bug / Other

Summary

If you notice in the source of the Greenwood website, the Apollo data and the webcomponents loader have a space before the closing bracket ( >) of the opening tag.

<script data-state="apollo" >
  window.__APOLLO_STATE__ = true;
</script>

  <!-- ... -->

  <script >
    /* ... */
  </script>

Details

It seems related to how these optimization attributes are being removed from the HTML during the optimization step as both of these leverage those custom attributes.

Probably good to make sure this isn't happening for <link> tags too.


Not a big deal but something worth looking into.

贡献者指南