PrismJS/prism

Keep Markup and zero-length tags

Open

#1,640 创建于 2018年11月30日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (11,488 star) (1,296 fork)batch import
bughelp wantedplugins

描述

The current implementation of the Keep Markup plugin does not handle zero-length tags (tags with textContent.length == 0) correctly.

It will move any nested zero-length tag at the end of its parent outside and after its parent, effectively flattening the markup structure. Examples:

  • <x><y></y></x> -> <x></x><y></y>
  • <x>a<y></y></x> -> <x>a</x><y></y>
  • <x>a<y></y><z></z></x> -> <x>a</x><y></y><z></z>
  • <x>a<y><z></z></y></x> -> <x>a</x><y></y><z></z>

贡献者指南

技术栈
javascript
领域
tooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Familiarity with PrismJSJavaScript knowledge
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Investigate the Keep Markup plugin in the PrismJS repository (likely in plugins/keep markup/). Look at the code that traverses the DOM and handles zero length tags. The issue describes the expected behavior: zero length tags should remain nested. To fix, identify where the plugin incorrectly detaches empty tags and adjust the logic to preserve their position. Consider adding test cases for the examples provided.
Keep Markup and zero-length tags · PrismJS/prism#1640 | Good First Issue