querySelectors are often casted instead of using the TS generic · PrestaShop/PrestaShop#27743

(0 评论) (1 反应) (0 负责人)PHP (7,621 star) (4,734 fork)batch import

BODeveloper FeatureFront-endGood first issueHacktoberfestImprovementPR available

描述

I understand and accept the project's code of conduct
I have already searched in existing issues and found no previous report of this bug.

There are a lot of querySelectors casted, but querySelector has a generic which can be used, in order to get the element type we want

Casting it is short-circuiting the TS typecheck, and it might lead to unwanted undefined elements

Instead of let test = document.querySelector('.test') as HTMLElement, we should use let test = document.querySelector<HTMLElement>('.test');

And then verify using Optional Chaining or a simple condition if the element exisit

It will ensure that every elements exist before using it and enforce our codebase, limit bugs...

No bug

8.x

No response

No response

技术栈: typescript
领域: frontend
议题类型: refactor
难度: 2
预计时间: 1-3 hours
活动状态: fresh
清晰度: clear
前置要求: Basic TypeScript knowledge
新手友好度: 80
研究方向: Search all TypeScript files in the repository for occurrences of `querySelector` followed by a type assertion (e.g., `as HTMLElement`). Replace each with the generic syntax `querySelector<HTMLElement>('.selector')` and add optional chaining (`?.`) or a null check before accessing properties. Ensure the element exists before usage to leverage TypeScript's type safety.