PostHog/posthog

Add pageleave warning to Feature Flags edit page if changes are not committed

已关闭

#5,187 创建于 2021年7月17日

在 GitHub 查看贡献者指南
 (19 条评论) (0 个反应) (1 位负责人)Python (988 个派生)batch import
enhancementfeature/feature-flagsgood first issueteam/feature-flags

仓库指标

星标
 (16,704 个星标)
PR 合并指标
 (平均合并 17小时 29分钟) (30 天内合并 995 个 PR)

描述

Is your feature request related to a problem?

It is way too easy to navigate away from the Feature Flags edit page without pressing "Save", losing all changes. I have done it probably a dozen times.

Describe the solution you'd like

Longer term, any changes to filter criteria should auto-save. But because this will probably require extra testing and implementation time, for now a browser message like "Are you sure? Changes may not be saved" would suffice.

Describe alternatives you've considered

Additional context

Thank you for your feature request – we love each and every one!

贡献者指南

研究方向
Look at the Feature Flags edit page component (likely in frontend/src/scenes/FeatureFlags/FeatureFlagsEdit.tsx). Add a beforeunload event listener that triggers when there are unsaved changes. Ensure the warning only shows when form is dirty. Review existing patterns for unsaved changes warnings in other edit pages in the codebase for consistency.
技术栈
typescriptreactcss
领域
frontend
议题类型
功能
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 小时
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
较久未更新
清晰度议题是否清楚说明期望改动、验收标准和下一步。
清晰
前置要求
ReactTypeScriptPostHog frontend conventionsbrowser event handling
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
75