PostHog/posthog

group flags that target groups should have default insights that only show `$feature_flag_called` events with groups associated with them

Open

#39,135 创建于 2025年10月4日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)Python (16,704 star) (988 fork)batch import
good first issueteam/feature-flags

描述

right now, we create default insights for feature flags, but if a feature flag targets groups, we should tailor that default insight to only show $feature_flag_called events that have groups set on them, since otherwise these events don't really evaluation traffic to this flag (i.e. it can make the rollout percentages seem confusing since the amount of false events (just bc there are no groups) will be way larger than expected)

Folks have been confused about this: https://posthog.slack.com/archives/C075EH38BR8/p1759134575502819

贡献者指南

技术栈
pythonpostgresql
领域
backendanalytics
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Understanding of PostHog feature flagsFamiliarity with default insights creationKnowledge of event properties filtering
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
The issue is to modify the default insight creation for feature flags that target groups. Look into how default insights are generated for feature flags (likely in plugin or insight creation code) and add a filter to only include $feature flag called events that have a 'groups' property. The Slack thread referenced (C075EH38BR8) may contain further details. Check the feature flag model and the default insight generation logic.