Bug: In Cohorts, the 'set' operator filters in null values for person properties · PostHog/posthog#29916

(3 评论) (0 反应) (1 负责人)Python (16,704 star) (988 fork)batch import

bugfeature/cohortsgood first issueteam/feature-flags

描述

Bug description

In Cohorts, 'set' operator filters in null values for person properties.

Expected outcome

'set' should filter out null values
'not set' should include null values

Using Have the property vs Does not have the property doesn't solve this because we want to filter out users who have the property but with a null value.

In filters, 'not set' filters in 'null while 'set' filters it out. This means there's an inconsistency with how we handle this in Cohorts.

How to reproduce

Create a cohort and filter by having a person property that you know some users have null for and select 'set'
notice the list of users includes users with 'null'

You can test with this cohort: https://us.posthog.com/project/53137/cohorts/122367

Additional context

From: https://posthoghelp.zendesk.com/agent/tickets/27021

Debug info

null

贡献者指南

技术栈: python
领域: backend
议题类型: bug
难度: 3
预计时间: 1-3 hours
活动状态: active
清晰度: clear
前置要求: Understanding of cohort filteringSQL null handling knowledgeFamiliarity with PostHog property filters
新手友好度: 50
研究方向: Investigate the cohort filtering logic in the backend, specifically the handling of null values for person properties. Look at the query building code for cohort definitions, likely in the `posthog/models/cohort` or `posthog/queries` directory. Compare the `set` and `not set` operators' behavior with person property filters. Ensure that the SQL query for 'set' excludes null values and 'not set' includes them. Refer to the existing filter logic in `PropertyFilter` classes.