PostHog/posthog

Feature Flag Hash Key Overrides table can grow out of control

Open

#16,885 创建于 2023年8月2日

在 GitHub 查看
 (5 评论) (0 反应) (0 负责人)Python (16,704 star) (988 fork)batch import
backlogbugfeature/feature-flagsgood first issueteam/flags-platform

描述

Bug description

The hashkeyoverrides table can grow seriously out of control because it keeps all rows for stale flags. We cascade delete, but since flags are soft deleted, this table doesn't clean itself up automatically, which makes it hard to keep the size manageable

Additional context

We should run a nightly/weekly job , or whenever a flag is deleted, to remove stale rows from this table.

Thank you for your bug report – we love squashing them!

贡献者指南

技术栈
pythonpostgresql
领域
backenddatabase
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Django ORMdatabase cleanup strategies
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
The issue requires implementing a cleanup mechanism for the hashkeyoverrides table. Currently, flags are soft deleted but the overrides table retains rows. A scheduled job (e.g., using Celery) should delete rows where the associated flag is soft deleted. Alternatively, a post delete hook could be added. Review the existing model definitions in posthog/models/feature flag.py and the soft deletion logic. Ensure the job is idempotent and efficient for large tables.
Feature Flag Hash Key Overrides table can grow out of control · PostHog/posthog#16885 | Good First Issue