PokemonGoF/PokemonGo-Bot

TODO: New evolutions - changes required and help needed

Open

#5,922 创建于 2017年2月19日

在 GitHub 查看
 (30 评论) (0 反应) (0 负责人)Python (3,816 star) (1,628 fork)batch import
Feature RequestHelp WantedNew Functionality

描述

Together with 0.57 we have new Pokemons released. This includes movesets and new evolutions. Now it is possible, that some pokemons can evolve to another (previously not available) Pokemons. Some of these evolution, requires a new item(s) : stones.

With 0.57 these new items has been added to the game:

  • 1101: Sun Stone
  • 1102: Kings Rock
  • 1103: Metal Coat
  • 1104: Dragon Scale
  • 1105: Upgrade

Currently bot knows about these new items, but it not aware, about evolution with them. So we have a challenges:

  1. Decide (by config? ) which evolution to take, if candies/stones requirements are met : evolve to Pokemon which doesn't require stone or to this one, which requires stone/rock ?
  2. Check if requirements are met. This can be done by hardcoding stones/rock in evolution logic, or by changing pokemon.json file (by moving NextEvolutionRequirements to Next Evolotuions/Pokemon )
  3. Changing pokemon.json will have a bigger impact on code change

We are open to suggestions and PRs around that. :-)

贡献者指南

技术栈
python
领域
backend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
understanding of Pokemon evolution mechanicsPython programmingJSON config structure
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
55
研究方向
Review the existing evolution logic in the codebase, likely in files handling Pokemon evolution and the pokemon.json configuration. Examine comments in issue #5922 for suggested approaches, especially regarding moving NextEvolutionRequirements to a per Pokemon structure. Consider the trade offs between hardcoding stones in evolution logic versus modifying pokemon.json, and evaluate the impact on existing code.