PointCloudLibrary/pcl

Bad info in pkgconfig file

Open

#4,240 创建于 2020年7月3日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)C++ (9,023 star) (4,506 fork)batch import
effort: lowgood first issuekind: bugkind: todo

描述

Just installed via All-In-One-Installer and wanted to point out that all of the pkgconfig .pc files installed have the wrong prefix path, it appears to be a relic of whoever builds the all-in-one-installer where their install prefix is set. The installer suggested to install into C:/Program Files/PCL 1.11.0 but wherever you install it, the pkgconfig files will always point to C:/Program Files/PCL image

I use PCL as an external dependency in another project I know how to get this working with the pkgconfig prefix issue, so I don't exactly need help. Just more a comment on what might give some people issues.

Originally posted by @WargodHernandez in https://github.com/PointCloudLibrary/pcl/issues/4069#issuecomment-652173534

贡献者指南

技术栈
cpp
领域
build systemtooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
CMake basicspkg configunderstanding of installation paths
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Locate the CMake configuration that generates the pkg config files (likely in CMakeLists.txt or a cmake module). Identify where the prefix path is hardcoded. Check the all in one installer scripts for any override. The fix should dynamically set the prefix based on the install prefix variable. Review the existing issue comments for any additional context.