ParadiseSS13/Paradise

/obj/docking_port/mobile keeps a hard reference of the last_caller

Open

#19,295 创建于 2022年10月5日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)DM (445 star) (1,313 fork)batch import
GC RelatedGood First Issue

描述

Issue Description: The mobile docking ports keep a hard reference to the last caller. /datum/controller/subsystem/shuttle/proc/moveShuttle is the proc which sets it.

[2022-10-05T20:51:06] Found /mob/dead/observer [0x300003b] in /obj/docking_port/mobile's [0x200057f] last_caller var. World -> /obj/docking_port/mobile

Steps to reproduce the problem:

  1. Spawn as a ghost or aghost.
  2. Use any shuttle console and call/send the shuttle
  3. Become a mob or something else to delete the ghost

When did the problem start happening: For a while. I have introduced it 2 years ago in #13208 :(

Extra information: It should use a UID here instead. This should be a relatively easy first GC issue.

贡献者指南

技术栈
无
领域
backend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic DM languageUnderstanding of garbage collection
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
The bug is in /datum/controller/subsystem/shuttle/proc/moveShuttle which sets last caller. The fix is to use a UID instead of a hard reference. Check PR #13208 where it was introduced. Implement a UID system for the docking port and modify the variable to store the UID.