POSYDON-code/POSYDON

Clean out duplicated functions and variables

已关闭

#442 创建于 2024年11月21日

 (0 条评论) (0 个反应) (0 位负责人)Python (35 个派生)auto 404
enhancementgood first issuev2 feature

仓库指标

星标
 (42 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

We have different functions and variables which have duplicates. We should clean that up to always use one version. Here some examples

  • posydon.utils.gridutils.kepler3_a vs. posydon.utils.common_functions.orbital_separation_from_period
  • posydon.utils.gridutils.T_merger_P vs. posydon.utils.common_functions.inspiral_timescale_from_orbital_period
  • posydon.utils.gridutils.T_merger_a vs. posydon.utils.common_functions.inspiral_timescale_from_separation
  • variables are often hard coded in functions instead of imported from where they are defined, this happens often in step_* vs. flow_chart

贡献者指南