OpenZeppelin/openzeppelin-contracts

Consider adding an ESLint rule for no async in describe blocks

已关闭

#4,943 创建于 2024年3月6日

 (6 条评论) (0 个反应) (0 位负责人)JavaScript (11,560 个派生)batch import
good first issuetests

仓库指标

星标
 (23,941 个星标)
PR 合并指标
 (平均合并 42天 15小时) (30 天内合并 16 个 PR)

描述

From @fvictorio:

I forgot to mention:

  • The wrong async keywords in describe functions can be prevented with this rule.
  • The missing await keywords are harder. Ideally you'd use typescript and the no-floating-promises rule, but I understand that that would be a huge undertaking.

Originally posted by @fvictorio in https://github.com/OpenZeppelin/openzeppelin-contracts/issues/4942#issuecomment-1980874051

We're considering adding only the ESLint rule and not migrating to Typescript to catch floating promises. However, we're open to alternatives.

贡献者指南