OpenXRay/xray-16

Get rid of Loki

开放

#240 创建于 2018年9月9日

 (3 条评论) (2 个反应) (0 位负责人)C++ (519 个派生)auto 404
Code QualityExternal (3rd party)Help wantedPortability

仓库指标

星标
 (3,524 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

Loki is a C++ library found in the sdk folder. There are several reasons to remove it:

  • Most of the stuff of this library, written for C++98 by Andrei Alexandrescu, can be found in C++11, e.g. Loki::Select is just std::conditional, Loki::IsSameType can be replaced with std::is_same.
  • Some of the code does not compile in GCC. (With some changes, it compiled in GCC)
  • The things that haven't been included in modern C++, can be rewritten with fewer lines of code.
  • It's barely used.

贡献者指南