OpenFeign/feign

feign-kotlin: dismiss404 doesn't work in CoroutineFeign

Closed

#2,026 创建于 2023年4月26日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)Java (9,070 star) (1,911 fork)batch import
bughelp wanted

描述

Hi! CoroutineBuilder does not set dismiss404 property so it is initialized with false when AsyncFeign is being created. Is this intended?

贡献者指南

技术栈
javakotlin
领域
backendapi
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
active
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaKotlinFeign basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
75
研究方向
The issue is that CoroutineBuilder in CoroutineFeign.java (line 160-181) does not propagate the dismiss404 property to AsyncFeign. To fix, locate CoroutineBuilder and ensure that the dismiss404 field is set on the AsyncFeign.Builder before building. Refer to how other properties like logLevel are passed. Also check existing tests for CoroutineFeign to add a test for this scenario.