OpenFeign/feign

ErrorDecoder not invoked when Apache Http client throws checked exception

Open

#1,487 创建于 2021年8月17日

在 GitHub 查看
 (8 评论) (0 反应) (1 负责人)Java (9,070 star) (1,911 fork)batch import
buggood first issuehelp wanted

描述

Hi, I have discovered issue when using feign.httpclient.ApacheHttpClient. In some cases Apache client throws ProtocolException which is a checked exception. This happens for example when server returned 303 HTTP code but there was no location header. In such case Feign proxy throws UndeclaredThrowableException instead of invoking ErrorDecoder.

贡献者指南

技术栈
java
领域
backend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaFeignApache HttpClient
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Investigate the ApacheHttpClient class in the feign httpclient module to understand how it currently handles checked exceptions like ProtocolException. The issue likely requires modifying the exception handling to ensure that such exceptions are caught and passed to the ErrorDecoder. Look for any comments or linked PRs from the assignee for additional context. Test with a scenario where a server returns 303 without a Location header to reproduce the problem.