OpenFeign/feign

RetryableException requires Request

Open

#1,296 创建于 2020年10月27日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)Java (9,070 star) (1,911 fork)batch import
help wantedproposal

描述

The constructors for RetryableException were updated in #1039 to require the original Request object. In some cases the Request may contain sensitive information and never be used from the RetryableException, so it would be nice to have an option to create one without the Request to limit surface area.

Additionally, FeignException already exposes a hasRequest() method, so clients would be able to check whether RetryableException has a Request before attempting to access it.

I'd be more than happy to open a PR if this sounds like a reasonable use case. Thanks!

贡献者指南

技术栈
java
领域
backendapi
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaFeign library
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Examine the RetryableException class in the source code to understand current constructors. Review the changes from PR #1039 that made Request required. Consider adding a new constructor that does not take Request, or making Request optional. Also check FeignException's hasRequest() method to ensure consistency. Create a PR with the changes and update tests accordingly.