OpenChemistry/avogadrolibs

Export to MP4 should test for "avconv" in path

开放

#282 创建于 2018年6月18日

 (2 条评论) (0 个反应) (1 位负责人)C++ (232 个派生)auto 404
bughacktoberfest

仓库指标

星标
 (662 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

https://github.com/OpenChemistry/avogadrolibs/blob/da6ebb9f0e39c73ca861001e390d13e6ed3e6cb5/avogadro/qtplugins/playertool/playertool.cpp#L249

This requires avconv to be installed in the system. If avconv is not installed, this particular snippet still executes, but no mp4 file is saved and there is no warning or error thrown saying that avconv is not found.

https://github.com/OpenChemistry/avogadrolibs/blob/da6ebb9f0e39c73ca861001e390d13e6ed3e6cb5/avogadro/qtplugins/playertool/playertool.cpp#L232 In Windows, the png export itself isn't taking place. avconv execution will also presumably fail I guess. Should we resort to including libraries for these in the build?

贡献者指南