OpenBagTwo/MarketWatch

Not all articles have a pillarName

开放

#4 创建于 2024年9月12日

 (0 条评论) (0 个反应) (0 位负责人)Jupyter Notebook (1 个派生)auto 404
buggood first issuehelp wantedquestion

仓库指标

星标
 (3 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

Had two runs over the past few weeks fail with the traceback:

Traceback (most recent call last):
  File "/home/runner/work/MarketWatch/MarketWatch/post_generator.py", line 297, in <module>
    generate_post(os.environ["GUARDIAN_API_KEY"], date)
  File "/home/runner/work/MarketWatch/MarketWatch/post_generator.py", line 265, in generate_post
    article = get_random_article(guardian_api_key, date)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/MarketWatch/MarketWatch/post_generator.py", line 196, in get_random_article
    "tags": [article["pillarName"]],
             ~~~~~~~^^^^^^^^^^^^^^
KeyError: 'pillarName'

The obvious solution would be to replace https://github.com/OpenBagTwo/MarketWatch/blob/9ff71afe656fdee5b829652634f6496695ca258b/post_generator.py#L196

with:

    "tags" :  [article["pillarName"]] if "pillarName" in article else [],

but the concern is that if this field is ever legitimately renamed, then no articles will have tags from then on.

I suggest looking into which articles don't have pillarNames—it's quite possible that they're not something I want to be pulling in the first place (in which case get_random_article should be rerun).

贡献者指南