Rust codegen creates incorrectly escaped parameter names · OpenAPITools/openapi-generator#1222

(1 评论) (0 反应) (0 负责人)Java (26,243 star) (7,516 fork)batch import

Client: RustHacktoberfestIssue: BugServer: Rusthelp wanted

描述

Description

Generating Rust APIs for Kubernetes or any other API using parameters names which match keywords generates invalid rust since the escaped parameters names are invalid.

The swagger file contains "continue" as a parameter. This gets escaped by the codegen to “_continue”. Unfortunately this fails to compile when used in a format macro:

error: invalid format string: invalid argument name `_continue`
     --> kubernetes/src/client/mod.rs:21864:99
      |
21864 |         let query__continue = param__continue.map_or_else(String::new, |query| format!("continue={_continue}&", _continue=query.to_string()));
      |                                                                                                   ^^^^^^^^^ invalid argument name in format string
      |
      = note: argument names cannot start with an underscore

OpenAPI declaration file content or url

https://raw.githubusercontent.com/kubernetes/kubernetes/release-1.11/api/openapi-spec/swagger.json https://raw.githubusercontent.com/kubernetes/kubernetes/master/api/swagger-spec/v1.json

Suggest a fix/enhancement

Could position, rather than parameter names, be used in the format string?

贡献者指南

技术栈: rustjava
领域: backendapitooling
议题类型: bug
难度: 4
预计时间: 1-2 days
活动状态: stale
清晰度: clear
前置要求: Familiarity with Rust string formattingUnderstanding of code generation patterns
新手友好度: 20
研究方向: The issue is in the Rust codegen module of openapi generator. Look at how parameter names are escaped (e.g., underscores prepended to keywords) and then used in format strings. The format macro fails because argument names cannot start with ' '. As suggested, consider using positional arguments like `format!("continue={0}", query)` or change the escaping logic to avoid leading underscores. Check the file `modules/openapi generator/src/main/resources/rust/libraries/reqwest/api.mustache` or similar templates.