NuGet/Home

Refactor UIActionEngineTests that use packagesFolder to avoid looking at the drive root

Open

#12,556 创建于 2023年4月24日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)HTML (1,459 star) (292 fork)batch import
Category:Quality WeekFunctionality:VisualStudioUIPriority:2Type:Testgood first issue

描述

@"\packagesFolder" seems like a bad idea. A single leading '' usually means "from the root of the drive" on Windows. A temporary directory or a local directory (@".\packgesFolder") seems better.

https://github.com/NuGet/NuGet.Client/pull/5109/files#r1175482193

贡献者指南

技术栈
csharp
领域
testing
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C# basicsunit testingNuGet client tests
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
90
研究方向
The issue is to refactor UIActionEngineTests that use a hardcoded path '\packagesFolder' to a temporary directory, as suggested in PR #5109. Look at the test file UIActionEngineTests (likely in the NuGet.Client repo) and replace occurrences of @"\packagesFolder" with a path like Path.Combine(Path.GetTempPath(), "packagesFolder") or use a test temp directory. Ensure the change is consistent with similar test patterns.