NixOS/nix

feat: substituter: show redirect destination on failure

Open

#9,998 创建于 2024年2月12日

在 GitHub 查看
 (0 评论) (1 反应) (1 负责人)C++ (9,803 star) (1,293 fork)batch import
error-messagesfeaturefetchinggood first issue

描述

Is your feature request related to a problem? Please describe.

I have a badly configured binary cache that is emitting an http 307.

The error is confusing because it doesn't show the redirect target url.

$ nix build -j0 "${REDACT}#output"
warning: error: unable to download 'https://redact.tar.gz': HTTP error 307 (curl error: Couldn't connect to server); retrying in 303 ms
warning: error: unable to download 'https://redact.tar.gz': HTTP error 307 (curl error: Couldn't connect to server); retrying in 617 ms
warning: error: unable to download 'https://redact.tar.gz': HTTP error 307 (curl error: Couldn't connect to server); retrying in 1388 ms
warning: error: unable to download 'https://redact.tar.gz': HTTP error 307 (curl error: Couldn't connect to server); retrying in 2044 ms
error:
       … while fetching the input 'https://redact.tar.gz'
       error: unable to download 'https://redact.tar.gz': HTTP error 307 (curl error: Couldn't connect to server)

In this case, "redact.tar.gz" is returning the 307 properly, and fine, but whatever server it's redirecting to isn't working.

Further, in this case, there are multiple redirects that curl is showing me, finally bottoming out on a host that is expectedly unreachable. But it's not shown in the error at all.

Describe the solution you'd like

Please show the redirect target URL in the error.

Describe alternatives you've considered n/a

Additional context n/a

Priorities

Add :+1: to issues you find important.

贡献者指南

技术栈
cpp
领域
cli
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
active
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C++Familiarity with Nix internals
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
The issue requests showing redirect targets when HTTP downloads fail. Look at the substitution code in `src/libstore/substitution goal.cc` and the download function in `src/libstore/download.cc`. The error message is built around curl's error string; you need to modify the code to include the redirect URL from curl's `CURLINFO REDIRECT URL`. Check existing error formatting in `download.cc` and ensure the redirect URL is displayed when a 307 occurs.