repl complete: support quoted attributes · NixOS/nix#13760

(0 评论) (8 反应) (0 负责人)C++ (9,803 star) (1,293 fork)batch import

featuregood first issueidea approvedrepl

描述

Is your feature request related to a problem?

Using nix repl complete on quoted attributes doesnt work. For example if it has . (dot symbol).

For example we have an attribute nixosConfiguration."test.server.example.com"

nix-repl> nixosConfigurations.test<TAB>
nix-repl> nixosConfigurations.test.server.example<TAB>
nix-repl> nixosConfigurations.test.server.example
nix-repl> nixosConfigurations."test<TAB>
nix-repl> nixosConfigurations."test
nix-repl> nixosConfigurations."test.server.example.com".<TAB>
nix-repl> nixosConfigurations."test.server.example.com".

Proposed solution

nix-repl> nixosConfigurations.test<TAB>
nix-repl> nixosConfigurations."test.server.example.com"
nix-repl> nixosConfigurations."test<TAB>
nix-repl> nixosConfigurations."test.server.example.com"
nix-repl> nixosConfigurations."test.server.example.com".<TAB>
attr1
attr2

Checklist

checked latest Nix manual (source)
checked open feature issues and pull requests for possible duplicates

Add :+1: to issues you find important.

贡献者指南

技术栈: cppshell
领域: clideveloper experience
议题类型: feature
难度: 3
预计时间: 1-3 hours
活动状态: fresh
清晰度: clear
前置要求: Basic knowledge of C++Understanding of nix REPLFamiliarity with tab completion logic
新手友好度: 60
研究方向: The issue involves modifying the tab completion logic in the nix REPL to handle quoted attribute names containing dots. Look at the REPL source code, likely in `src/nix/repl.cc` or similar. The current behavior completes partial unquoted names but fails for quoted ones. The proposed solution suggests completing the full quoted string. Check if there is existing handling for quoted strings and extend it. The maintainers have not yet commented, so the approach should be based on the feature request.