NethermindEth/starknet.go

Specific return type for BlockWithTxs and BlockWithTxHashes methods

开放

#355 创建于 2023年9月22日

 (1 条评论) (0 个反应) (0 位负责人)Go (140 个派生)auto 404
help wanted

仓库指标

星标
 (177 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

In https://github.com/NethermindEth/starknet.go/pull/354 a new type for blocks with only transaction hashes was created as requested on #347.

However, BlockWithTxs and BlockWithTxHashes methods still have as return type interface{} as these can return either a Block or a Pending Block in both cases. The idea is to replace interface{} with an specific type and do something similar as in TransactionByHash method (see here) with adaptTransaction

贡献者指南