Netflix/security_monkey

What does the Change Emails "With Issues" option mean under notification settings?

Open

#945 创建于 2018年2月15日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)Python (4,341 star) (832 fork)batch import
bughelp wanted

描述

Under notification settings, I set Change Emails to be "With Issues" and set EMAIL_AUDIT_REPORTS_INCLUDE_JUSTIFIED=False in the config. I assumed this meant it would only email me on changes with unjustified issues, however I still get emails for changes that have no issues at all (e.g. creating / deleting RDS snapshots, updating route 53 records, etc.). Is this a bug or am I not understanding what "With issues" means? Also, I am using the code in the develop branch fetched 2-14.

Thanks!

贡献者指南

技术栈
pythonaws
领域
securitybackend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Basic PythonSecurity Monkey notification settings
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Investigate the notification settings logic in the Security Monkey codebase, particularly around the 'With Issues' option and the EMAIL AUDIT REPORTS INCLUDE JUSTIFIED configuration. Look at the source files for email notifications (e.g., `security monkey/notification utils.py` or similar) to understand the condition used to filter changes. Check the two comments on the issue for any additional details or hints. Identify whether the logic correctly excludes changes without issues or if there is a bug that sends emails for all changes regardless.