MonoGame/MonoGame

EffectParameter Get/Set methods missing for several data types

Open

#6,119 创建于 2017年12月25日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)C# (13,886 star) (3,071 fork)batch import
Good First IssueHelp Wanted

描述

Based on the following: https://msdn.microsoft.com/en-us/library/microsoft.xna.framework.graphics.effectparameter_methods(v=xnagamestudio.40).aspx

Missing these methods and their SetValue overload counterparts: GetValueInt32Array GetValueBooleanArray GetValueMatrixTranspose // this one does have a set method GetValueMatrixArrayTranspose GetValueQuaternionArray

贡献者指南

技术栈
csharp
领域
api
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C#MonoGameEffectParameter class
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Look at the existing EffectParameter.cs file in the MonoGame repository to understand how GetValue and SetValue methods are currently implemented for other types. The issue references MSDN documentation for the method signatures. Implement the missing methods by following the pattern of existing ones, such as GetValueInt32Array, SetValueBooleanArray, etc. Note that GetValueMatrixTranspose already has a set counterpart, so implement the get version. Use the same data marshalling techniques used in the existing methods.