Miserlou/Zappa

undeploy didn't nuke my apigw custom domain

Open

#698 创建于 2017年3月1日

在 GitHub 查看
 (7 评论) (0 反应) (0 负责人)Python (11,903 star) (1,286 fork)batch import
bughacktoberfesthelp wanted

描述

Context

I did a 'zappa undeploy production' for a project with a 'domain' set under 'production'.

Expected Behavior

I expected that to correctly remove the apigw entries that it created.

Actual Behavior

It removed the API-GW API, but not the 'Custom Domain Name' that it was using. The custom domain was 'emptied', however, in that it no longer listed any API Mappings, but I can't tell if that was Zappa doing its job or AWS nuking a reference to a no-longer-existing API entry.

Possible Fix

Your Environment

  • zappa --version => 0.37.1
  • linux (ubuntu 16.04)
  • python -V => 2.7.12

贡献者指南

技术栈
pythonawsrest api
领域
devopscloud
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
AWSPythonZappa
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
The issue involves the Zappa undeploy command not removing the API Gateway custom domain. To fix, examine the undeploy logic in the Zappa source code (likely in `zappa/cli.py` or `zappa/deploy.py`). Look for the part that deletes the API and ensure a similar deletion step for the custom domain using the AWS API. Also review the issue comments (#698) for any guidance or attempted solutions.
undeploy didn't nuke my apigw custom domain · Miserlou/Zappa#698 | Good First Issue