Mikhus/domurl

Hash is encoded but...

Open

#28 创建于 2016年12月6日

在 GitHub 查看
 (1 评论) (2 反应) (0 负责人)JavaScript (531 star) (100 fork)batch import
help wanted

描述

I dont know if it's the right behavior. I'm actually using backbone and the way to describe routes (like many front-end framework) is with hash like foo/1 which become foo%2F1 when using domurl to manipulate query parameters.

贡献者指南

技术栈
javascript
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
JavaScriptURL encoding basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Investigate the domurl library's handling of hash fragments and URL encoding. The issue reports that forward slashes in hash routes (e.g., 'foo/1') are being percent encoded to '%2F' when using domurl to manipulate query parameters. Check the source code (likely in src/url.js or similar) for how query parameters and hash are parsed and serialized. Determine if the encoding is intentional or a bug. Consider whether the fix should preserve the original encoding of the hash or apply only to query parameters.