Microsoft/vscode

Custom editors cannot be opened when a single-folder workspace has Been Extended To A Multi-Folder Workspace

Open

#98,603 创建于 2020年5月26日

在 GitHub 查看
 (3 评论) (0 反应) (1 负责人)TypeScript (74,848 star) (10,221 fork)batch import
bugcustom-editorshelp wantedwebview

描述

  • VSCode Version: 1.45.1 / Insiders 2020-05-26T15:51:05.752Z
  • OS Version: Windows 10 / Mac

Steps to Reproduce:

  1. Check out Cat Customs Sample
  2. Install the extension
  3. Copy the exampleFiles folder to exampleFiles2
  4. Open a new VS Code Instance with exampleFiles as root folder
  5. (Custom Editor works as intended)
  6. Add exampleFiles2 to the workspace.
  7. Open example.cscratch in exampleFile2 folder.
  8. It crashes.

Does this issue occur when all extensions are disabled?: Yes

You can see this happening with my draw.io extension too: https://github.com/hediet/vscode-drawio/issues/61

贡献者指南

技术栈
typescriptjavascriptnodejs
领域
desktopdeveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
3-5 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
VS Code extension APICustom editor conceptsWorkspace model
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Investigate the custom editor provider lifecycle when transitioning from a single folder to a multi folder workspace. Look at the 'vscode extension samples/custom editor sample' for reproduction. Examine VS Code source code in 'src/vs/workbench/services/editor' and 'src/vs/platform/workspace' for handling workspace changes. The crash likely occurs due to incorrect URI handling or editor registration when additional folders are added. Check the draw.io extension issue for similar behavior.