Microsoft/vscode

[folding] Move line up/down should skip over folded regions or folded sections

Open

#63,972 创建于 2018年11月29日

在 GitHub 查看
 (14 评论) (75 反应) (1 负责人)TypeScript (74,848 star) (10,221 fork)batch import
editor-commandseditor-foldingfeature-requesthelp wanted

描述

  • VSCode Version:1.30.0-insider
  • OS Version: windows 10

I think when code is in a folded region or section it should never unfold unless explicitly commanded, so if you are moving a line using move command, the line should skip over both folded regions and folded sections Steps to Reproduce:

  1. create a folded region using #region #endregion
  2. fold some code section
  3. move a line using alt+up/down over the folded region/section vscodemovelinebug

Does this issue occur when all extensions are disabled?: Yes

贡献者指南

技术栈
typescript
领域
developer experiencetooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
VS Code editor architectureFolding APILine move commands
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Investigate the move line command implementation in the VS Code editor, specifically the `editor.action.moveLinesUpAction` and `editor.action.moveLinesDownAction`. Examine how folding regions are handled in the `FoldingController` and `FoldingRangeProvider`. Review existing comments for potential approaches, such as skipping fold ranges during selection. Consider whether to modify the `MoveLinesCommand` or add a new option to avoid unfolding.