Microsoft/vscode

[scss] selector specificity works wrong with nested selectors

Open

#63,200 创建于 2018年11月15日

在 GitHub 查看
 (3 评论) (10 反应) (1 负责人)TypeScript (74,848 star) (10,221 fork)batch import
bugcss-less-scsshelp wanted

描述

Issue Type: Bug

Css specifity calculator doesn't respect nested selectors or selectors with &.

#id {} /* (1, 0, 0) */

#id div {} /* (1, 0, 1) */

#id {
  div { /* (0, 0, 1) */
  }
}

.block{ /* (0, 1, 0) */
  &__element { /* (0, 0, 0) */
  }
}

Reproduced without any extensions

VS Code version: Code 1.29.0 (5f24c93878bd4bc645a4a17c620e2487b11005f9, 2018-11-12T07:47:15.448Z) OS version: Windows_NT x64 10.0.17134

贡献者指南

技术栈
csstypescript
领域
developer experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
CSS specificity rulesSCSS nesting syntax
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
35
研究方向
Investigate the CSS specificity calculation in the VS Code CSS language service, likely in the `extensions/css language features/server` directory. The bug is that nested selectors and `&` in SCSS are not being expanded correctly before specificity calculation. Look at the parser and selector specificity logic to understand how nested rules are handled. Since the issue is old and has an assignee but no linked PR, check the assignee's activity and consider fixing the expansion of nested selectors before computing specificity.