Microsoft/vscode

[Emmet] Include should be more like DocumentSelector

Open

#49,588 创建于 2018年5月10日

在 GitHub 查看
 (11 评论) (0 反应) (1 负责人)TypeScript (74,848 star) (10,221 fork)batch import
emmetfeature-requesthelp wanted

描述

Currently, the Emmet extension has a setting called emmet.includeLanguages which just targets language IDs to map to the Emmet-capable language ID. I think it would be very useful if instead you could use something more like DocumentSelector, which also allows DocumentFilter instead of just language ID.

贡献者指南

技术栈
typescript
领域
developer experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
VSCode extension APIEmmet extension internals
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
This issue is assigned to a maintainer. The change requires modifying the `emmet.includeLanguages` setting in `extensions/emmet/package.json` and the corresponding activation logic in `extensions/emmet/src/` to support `DocumentSelector` objects. Review the VSCode API documentation for `DocumentFilter` and `DocumentSelector` to understand the new structure. The existing comments provide some discussion on possible approaches. Ensure backward compatibility with the current string only format.