Support naming settings.json as settings.jsonc (and others) · Microsoft/vscode#269824 | Good First Issue

(13 评论) (5 反应) (1 负责人)TypeScript (10,221 fork)batch import

feature-requesthelp wantedsettings-editor

仓库指标

Star: (74,848 star)
PR 合并指标: (平均合并 11小时 43分钟) (30 天内合并 1,000 个 PR)

描述

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.104.2
OS Version: Linux

Steps to Reproduce:

Create .vscode/settings.json, .vscode/extensions.json, etc.
Put a comment into that "JSON", as allowed by https://jsonc.org, used implicitly by VSC
Use any other of about a billion existing tool which assumes that *.json are https://www.json.org and not https://jsonc.org
See that tool fail, e.g. https://github.com/pre-commit/pre-commit-hooks/issues/1196

This was already reported in https://github.com/microsoft/vscode/issues/79744 over 6+ years ago.

Would a PR to add support for this be welcome?

贡献者指南

研究方向: 调查 VS Code 如何加载设置文件（例如 settings.json）以及检查文件扩展名的位置。查看 JSONC 解析器的使用和文件监视器配置。PR 需要添加对 .jsonc 扩展名（与 .json 一起）的支持。
技术栈: typescript
领域: developer experience
议题类型: 功能
难度: 2
预计时间: 半天
活动状态: 活跃
清晰度: 清晰
前置要求: GitTypeScript
新手友好度: 70