Microsoft/vscode

Cannot use arrow keys to go to toggle icon in notebook find widget

Open

#207,765 创建于 2024年3月14日

在 GitHub 查看
 (1 评论) (0 反应) (1 负责人)TypeScript (10,221 fork)batch import
accessibilitybughelp wantednotebook-find

仓库指标

Star
 (74,848 star)
PR 合并指标
 (平均合并 11小时 43分钟) (30 天内合并 1,000 个 PR)

描述

  1. Open a notebook and CTRL+F
  2. Use tab on the find action buttons- notice that this allows you to navigate to all of the different buttons.
  3. Use right/left arrow on the find action buttons- notice that this only loops between the first three.

I think the problem is here: https://github.com/microsoft/vscode/blob/a984153d6a98fba04f0a39a5ab9918c7b6e47511/src/vs/base/browser/ui/findinput/findInput.ts#L170-L194

The arrow key navigation is fixed at the findInput level, and we aren't adding to it, even when adding the funnel icon.

In this screencap, I accidentally press the down key-- that's not part of the demo 😅 https://github.com/microsoft/vscode/assets/31675041/9949cd63-a57c-42e3-9fd8-0d03de6f44cb

贡献者指南