Microsoft/vscode

[webviews] deserializeWebviewPanel is not called when switching workspace trust to restricted

Open

#195,009 创建于 2023年10月6日

在 GitHub 查看
 (0 评论) (0 反应) (1 负责人)TypeScript (74,848 star) (10,221 fork)batch import
bughelp wantedwebview

描述

Does this issue occur when all extensions are disabled?: Yes/No

It is a custom extension which uses the Webview Api.

  • VS Code Version: 1.83.0
  • OS Version: Ubuntu 23.04

Steps to Reproduce:

  1. Use a webview which implements deserializeWebviewPanel
  2. Write console.log() statements when extension starts, ends, registers deserializeWebviewPanel and inside deserializeWebviewPanel
  3. Notice that on VSCode reload deserializeWebviewPanel is called, on workspace trust change to false the extension is reloaded but deserializeWebviewPanel is not called.
  4. The webview becomes unusable as it is not tracked anymore by the extension (trust=false restarts extension apparently).

First lines are printed when Reload Window is triggered. Last lines when switching the workspace trust to false: Screenshot from 2023-10-06 17-17-51

Possible workarounds:

Use onDidGrantWorkspaceTrust which is fired only when trusting the workspace + window.tabGroup Api (available from 1.67) to find the Panel and reuse it.

贡献者指南

[webviews] deserializeWebviewPanel is not called when switching workspace trust to restricted · Microsoft/vscode#195009 | Good First Issue