Microsoft/vscode

Custom editors should not allow to make edits after extension host restart

Open

#184,142 创建于 2023年6月2日

在 GitHub 查看
 (2 评论) (1 反应) (1 负责人)TypeScript (10,221 fork)batch import
bugcustom-editorshelp wanted

仓库指标

Star
 (74,848 star)
PR 合并指标
 (平均合并 11小时 43分钟) (30 天内合并 1,000 个 PR)

描述

This is a follow up from https://github.com/microsoft/vscode/issues/180514

When the EH restarts with an opened custom editor, that editor continues to be editable but does not report any dirty indication and does not allow to be saved because the old EH it was talking to is gone.

Recording 2023-06-02 at 10 50 46

I think a custom editor should detect that it lost the connection to its extension on the EH side and then do something, such as:

  • turn readonly to prevent further edits
  • show an indication to the user what happened

//cc @Tyriar

贡献者指南