Microsoft/vscode

Blocked popups are not handled in Chrome on Github Codespace

Open

#165,339 创建于 2022年11月3日

在 GitHub 查看
 (3 评论) (3 反应) (1 负责人)TypeScript (10,221 fork)batch import
bughelp wantedopenerweb

仓库指标

Star
 (74,848 star)
PR 合并指标
 (平均合并 11小时 43分钟) (30 天内合并 1,000 个 PR)

描述

When using GitHub Codespaces, if an extension tries to spawn a new browser window it's blocked by Chrome:

Screenshot 2022-11-03 at 10 58 41

This issue was discussed in the context of Safari in #118731 and it seems like a fix was applied (that detects the blocking, then prompts the user so that the window can be re-triggered from a user-click which would not trigger the blocking), but from the discussion it's not clear if this was only applied to Safari (@isidorn may be able to confirm - I can't see anything Safari specific in the linked commits I reviewed). I certainly don't see that notification in Chrome.

The API called that triggered this was vscode.env.openExternal. It was tested today on the current live version of GitHub workspaces (and latest stable version of Chrome).

If I allow github.dev to spawn popups in Chrome settings, ofcourse everything works fine - but that only solves the problem for me and not other users.

贡献者指南