Microsoft/vscode

Webviews disables Alt key menu navigation

Open

#121,379 创建于 2021年4月15日

在 GitHub 查看
 (0 评论) (0 反应) (1 负责人)TypeScript (74,848 star) (10,221 fork)batch import
bughelp wantedwebviewwindows

描述

Version: 1.55.2 Commit: 3c4e3df9e89829dce27b7b5c24508306b151f30d Date: 2021-04-13T09:37:02.931Z Electron: 11.3.0 Chrome: 87.0.4280.141 Node.js: 12.18.3 V8: 8.7.220.31-electron.0 OS: Linux x64 5.8.0-48-generic

Steps to Reproduce:

  1. Open VS code.
  2. Create markdown file and populate with simple text.
  3. Open file preview with CTRL+SHIFT V.
  4. Whilst in file preview, hold ALT --> no menu bar navigation.

Does this issue occur when all extensions are disabled?: Yes

贡献者指南

技术栈
typescripthtmlcss
领域
frontendaccessibility
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
TypeScriptElectronVS Code source code structureKeyboard event handling
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
This issue involves a bug where Alt key menu navigation is disabled when a webview (e.g., markdown preview) has focus. To fix, one needs to understand how VS Code's webview handles keyboard events and how the menu bar listens for Alt key. The relevant code is likely in `src/vs/workbench/contrib/webview/` and `src/vs/platform/keybinding/`. First, reproduce the issue with current VS Code version. Then, check if the webview's event handler correctly forwards the Alt key to the menu bar. The issue has an assignee but no open PR, so discuss with maintainers before starting. Potential solution involves modifying the webview's keydown event listener to not prevent default for Alt key when menu navigation is desired.