Microsoft/vscode

SCM - improve focus movement

Open

#116,755 创建于 2021年2月16日

在 GitHub 查看
 (0 评论) (0 反应) (1 负责人)TypeScript (74,848 star) (10,221 fork)batch import
accessibilitybughelp wantedscmteam-low-hanging

描述

I did some improvements in the ActionBar focus which I think reflect positively in the SCM view. However there is still two corner cases which I think we could improve:

  1. Focus onto an element in Changes view, press tab -> focus jump to inline actions (great)
  2. Press shit + tab -> focus is moved to the Message box 🐛

It would be cool if tab and shift+tab are always paired, thus shift+tab after a tab would bring you back to the original item.

One more corner case

  1. Focus onto the first item in changes
  2. Press shift + tab -> focus is moved in title bar actions 🐛
  3. I would expect the focus to move into the commit box

Overall I think the focus navigation in SCM works nice, thanks to this "top level" up and down navigation which allows to focus into something.

fyi @joaomoreno

贡献者指南

技术栈
typescript
领域
desktopaccessibility
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
familiarity with TypeScriptunderstanding of keyboard navigation patterns
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Examine the SCM view focus handling code, particularly the Changes view and inline actions. Look for tab keybindings and ensure tab/shift+tab are symmetric. Investigate the focus transition from the first item's shift+tab to the commit box rather than the title bar. Review recent ActionBar focus improvements mentioned.