Microsoft/vscode

Git - Removing a folder from multi-root workspace does not remove repo

Open

#108,757 创建于 2020年10月15日

在 GitHub 查看
 (14 评论) (3 反应) (1 负责人)TypeScript (74,848 star) (10,221 fork)batch import
buggitgood first issuehelp wantedteam-low-hanging

描述

Version: 1.50.1 (user setup) Commit: d2e414d9e4239a252d1ab117bd7067f125afd80a Date: 2020-10-13T15:06:15.712Z Electron: 9.2.1 Chrome: 83.0.4103.122 Node.js: 12.14.1 V8: 8.3.110.13-electron.0 OS: Windows_NT x64 10.0.19041

Steps to Reproduce:

  1. Create a multi-root workspace:

    • folder_A contains git-repo A
    • folder_B contains git-repo B

    SCM pane shows repo A and repo B

  2. Remove folder_B from workspace

    SCM pane still shows repo B (expected: repo B is automatically closed/removed)

  3. Select "close repo" on repo B

    repo B vanishes from SCM pane

  4. reopen workspace

    SCM pane again shows repo B (expected: repo B does no longer show up)

Workaround: Delete workspace settings under C:\Users\<username>\AppData\Roaming\Code\User\workspaceStorage.

Does this issue occur when all extensions are disabled?: Yes/No

贡献者指南

技术栈
typescript
领域
frontenddeveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
VSCode source code navigationTypeScriptGit SCM extensionworkspace storage model
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Investigate the SCM view model and workspace storage logic in vscode. The bug likely lies in how the Git extension tracks repositories from workspace folders. Focus on the `git` extension's `repository` model and the workspace's folder removal event handling. Refer to comments in the issue for discussion on potential fixes.