Microsoft/vscode

Add selection to next Find match does not work with Regex Find Mode

Open

#107,090 创建于 2020年9月20日

在 GitHub 查看
 (7 评论) (10 反应) (2 负责人)TypeScript (74,848 star) (10,221 fork)batch import
bugeditor-findeditor-multicursorgood first issuehelp wanted

描述

Description

Adding selection to next find match does not work when the regex find mode is turned on. I am not sure this is intended, but based on #5715 I would assume you would want this to work along with adding everything to the selection so I'm calling it a bug.

I made an example of this in the gif below while in an instance with extensions disabled by running code --disable-extensions and with me just trying to add to the selection using ctrl+d

VscodeRegexctrld

Version Info

VSCode Version: 1.48.2 (system setup) Commit: a0479759d6e9ea56afa657e454193f72aef85bd0 Date: 2020-08-25T10:13:11.295Z Electron: 7.3.2 Chrome: 78.0.3904.130 Node.js: 12.8.1 V8: 7.8.279.23-electron.0 OS: Windows_NT x64 10.0.18363

Steps to Reproduce:

  1. Open any document with some text
  2. Turn on the regex mode for the search tool
  3. Add some valid regex pattern
  4. Attempt to add another cursor by pressing ctrl+d

Does this issue occur when all extensions are disabled?: Yes

贡献者指南

技术栈
typescriptjavascript
领域
developer experiencetooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Familiarity with VS Code codebaseRegex knowledge
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Investigate the find widget implementation in VS Code's source code, specifically the logic for 'Add Selection to Next Find Match' with regex mode. The issue references #5715 which may provide additional context. The relevant code is likely in 'src/vs/editor/contrib/find' directory. Since there are assignees, check their progress or any linked branches.