Microsoft/vscode

macOS: Crash when using `fs.watch` for network drives

Open

#106,879 创建于 2020年9月16日

在 GitHub 查看
 (21 评论) (3 反应) (1 负责人)TypeScript (74,848 star) (10,221 fork)batch import
bugconfirmedfile-iofile-watcherfreeze-slow-crash-leakhelp wantedmacosnodejsupstreamupstream-issue-pending

描述

On MacOS 10.15 when a file is open from an SMB share if connection t othe SMB share is lost the entire editor crashes.

To repro: Open finder and Connect to Server open a file from the mapped SMB drive in VS Code disconnect the network return to VS Code VS Code crashes

Expected behavior would be 'file no longer exists' or something similar

贡献者指南

技术栈
typescriptnodejselectron
领域
desktop
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Familiarity with Node.js fs moduleUnderstanding of Electron main process
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
20
研究方向
Investigate the crash in VS Code's file watching when network connection drops on macOS. Start by examining the file watcher implementation in src/vs/platform/files/node/watcher.ts. Review the Electron NativeFileWatcher behavior on macOS, possibly related to an existing Electron issue. Check comments in the issue for any suggested fixes or workarounds. Consider testing with a minimal Electron app using fs.watch on SMB shares to isolate the problem.