Microsoft/monaco-editor

TS regex missed by Monarch grammar

Open

#2,512 创建于 2021年6月2日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (14,836 star) (1,283 fork)batch import
buggrammarshelp wantedtypescript

描述

Extracted from https://github.com/microsoft/TypeScript-Website/issues/1870

const x = true ? /^([^"]*)"/ : /^([^']*)'/

/^([^"]*)"/ is not identified as a regex by the TS Monarch grammar, which breaks bracket matching:

image

贡献者指南

技术栈
typescript
领域
developer experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Understanding of Monarch tokenizerFamiliarity with TypeScript syntaxBasic regex knowledge
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
The bug occurs in the TypeScript Monarch grammar at line 76 of typescript.ts (https://github.com/microsoft/monaco languages/blob/319a1ddf568438d59a3851784b092cdf1f88e29e/src/typescript/typescript.ts). The regex pattern after a ternary operator is not being tokenized as a regex. To fix, examine the tokenizer rules for handling '/' after conditional expressions and ensure regex detection works for patterns like `/^([^"]*)"/` and `/^([^']*)'/`. Consider adding a state or rule to differentiate division from regex in such contexts.