Microsoft/monaco-editor

[Monarch Julia grammar] interpolation breaks inside multiline strings

Open

#2,357 创建于 2021年2月17日

在 GitHub 查看
 (0 评论) (1 反应) (0 负责人)JavaScript (14,836 star) (1,283 fork)batch import
buggrammarshelp wanted

描述

monaco-editor version: 0.22.3 Browser: Google Chrome 88.0.4324.182 (Official Build) (64-bit) (cohort: 88_Win_182) OS: Windows 10

Hi!

Using the built-in julia mode, string interpolation inside a multiline string seems to break the syntax highlighting whenever any right parenthesis ) is encountered, not just the final one that closes the interpolation. Example:

Multiline_interpolation_breaks_in_monaco

I had a little go at it but I have to learn more about Monarch before I can be of any use here. Here's a codesandbox with some more test cases, and an editable copy of the current julia mode included with monaco-editor for easy experimenting.

贡献者指南

技术栈
typescriptjavascript
领域
frontenddeveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic understanding of Monarch grammarsknowledge of Julia string interpolation
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Investigate the current Julia Monarch grammar file (likely at src/basic languages/julia/julia.ts). Use the provided CodeSandbox to reproduce the bug where interpolation breaks on encountering ')' inside multiline strings. The grammar's string interpolation rules need to be updated to handle multiline context. Study how other language grammars in Monaco handle similar cases for reference.