Microsoft/monaco-editor

Keyword "field" is highlighted in Kotlin package names

Open

#2,351 创建于 2021年2月14日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (14,836 star) (1,283 fork)batch import
buggrammarshelp wanted

描述

Create Kotlin file foo.kt with content:

package com.boo.field
import com.foo.field.bar

View it it Azure DevOps web commit history, web editor or PR view (anywhere where code is displayed), notice "field" is highlighted blue. This is because "field" is keyword in Kotlin, but keywords should not apply for package names.

Note: this issue was redirected to monaco by Azure Dev Ops support: "This issue seems to be caused by Monaco-languages and not Visual Studio. Please file a ticket with that product at https://github.com/microsoft/monaco-languages" https://developercommunity2.visualstudio.com/t/DevOps-code-viewer-highlights-field-in/1299514?entry=myfeedback&space=21

贡献者指南

技术栈
javascripttypescript
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Familiarity with Monaco language definitionsBasic understanding of Kotlin syntax
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
The issue is in the Kotlin language grammar definition in the monaco languages repository. Look for the Kotlin tokenizer/grammar file (likely written in TypeScript). The keyword 'field' should be removed from the keyword list or the matching rules should ensure it is only highlighted as a keyword in certain contexts (not in package names). Check the monaco languages Kotlin grammar and modify the tokenization rules to exclude 'field' from keyword highlighting when it appears in package declarations.