Microsoft/monaco-editor

Chinese IME does not work correctly with CompletionItemProvider

Open

#2,199 创建于 2020年10月20日

在 GitHub 查看
 (5 评论) (2 反应) (0 负责人)JavaScript (14,836 star) (1,283 fork)batch import
bugeditor-input-IMEhelp wantedsuggest

描述

If set suggestion label as a chinese text, the auto complete item will never show when input with chinese IME like sougou.

And I found that the suggestion check is triggered in 'compositionupdate' event instead of 'compositionend,' then the selection check is failed, the preSelection(typed alpha text) is after currentSelection(chinese text):

//  in suggestModel.js : _onCursorChange

(!prevSelection.containsRange(this._currentSelection) && !prevSelection.getEndPosition().isBeforeOrEqual(this._currentSelection.getPosition()))

In vscode there is same problem. the snippets with chinese label doesn't not work.

贡献者指南

技术栈
javascripttypescript
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
understanding of IME composition eventsknowledge of JavaScript event handling
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Examine suggestModel.js, specifically the onCursorChange method where compositionupdate event handling is used. Compare with compositionend event. Check if the condition on line mentioned (preSelection after currentSelection) can be adjusted. Also review Monaco's handling of IME input and any existing vscode workarounds.