Microsoft/TypeScript

Do not rename imports from ambient modules

Open

#8,227 创建于 2016年4月20日

在 GitHub 查看
 (6 评论) (3 反应) (0 负责人)TypeScript (48,455 star) (6,726 fork)batch import
Effort: ModerateHelp WantedSuggestion

描述

Issue explained by @bbgone in https://github.com/Microsoft/TypeScript/issues/8118#issuecomment-212218038

Renaming an import alias for a module coming from a .d.ts file, renames all instances. this is obviously wrong.

Options, 1. error (obviously not helpful), 2. only rename local symbol (better, but leaves the code in an invalid state), 3. rename local import and add as oldname clause to the import declaration as needed (looks like the best solution).

This is similar to the issue related to https://github.com/Microsoft/TypeScript/issues/7458, except that this issue adds renaming the import alias.

贡献者指南

技术栈
typescript
领域
tooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
3-5 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
TypeScript module systemCompiler rename logicAmbient module declarations
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Investigate the TypeScript compiler's rename functionality, particularly how imports from .d.ts files are handled. The issue suggests that renaming an import alias from an ambient module incorrectly renames all instances. Proposed solution is to rename only the local symbol and add an 'as oldname' clause. Examine the relevant code in the compiler's rename module to identify where the global rename occurs and modify it to handle ambient modules differently, ensuring the fix aligns with existing behavior for non ambient modules.