Microsoft/TypeScript

Ternary operator breaks syntax highlighting in tsx file

Open

#56,696 创建于 2023年12月6日

在 GitHub 查看
 (0 评论) (1 反应) (0 负责人)TypeScript (48,455 star) (6,726 fork)batch import
BugDomain: JSX/TSXHelp Wanted

描述

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.84.2
  • OS Version: Windows 11 build 22621

Steps to Reproduce:

  1. Create a .tsx file
  2. Paste this code
import { useState } from "react"
import './OS.css'
import Window from './Window'

const OS = () => {
    const [loaded, setLoaded] = useState(false);

    return (
        loaded ?
            <div id="OS">

            </div>
            :
            <div id="loading">
                <Window title="Starting Up">

                </Window>
            </div>
    )
}

export default OS

All editor features will be broken in the second half of the ternary operator. No tag closing, no indentation, and syntax highlighting is funky image

贡献者指南

技术栈
typescriptreact
领域
developer experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
TypeScript language service internalsJSX parsing
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Investigate the TypeScript language service's syntax highlighting logic for JSX elements inside ternary expressions. The bug indicates that the tokenizer or semantic token provider incorrectly handles the alternate branch of a ternary when it contains JSX. Look at files like src/services/syntaxHighlighter.ts or src/compiler/scanner.ts. Check if any recent changes to JSX parsing or ternary handling could have introduced this issue.