Microsoft/TypeScript

Enum types are not checked in binary operators

Open

#3,845 创建于 2015年7月13日

在 GitHub 查看
 (5 评论) (0 反应) (0 负责人)TypeScript (48,455 star) (6,726 fork)batch import
Breaking ChangeBugDomain: enumHelp Wanted

描述

I ran into this for real while trying to fix a bug in the compiler. We disallow assigning one enum to another if you use the = operator. But we do not disallow it for any of the compound assignment operators. Nor do we disallow for bitwise operators. I think we should disallow all of them.

enum E { }
enum F { }

var e: E;
var f: F;

e = f; // Error
e |= f; // No error
var g = e | f; // No error, g is number

贡献者指南

技术栈
typescript
领域
tooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic understanding of TypeScript's type systemFamiliarity with compiler source code
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
The issue describes that enum type checking is missing for compound assignment operators (e.g., |=) and bitwise operators. To fix this, locate the type checking logic for binary operators in the TypeScript compiler, likely in checker.ts. Study how the '=' operator checks enum types and extend that logic to other operators. Check for any existing test cases for enum assignment to ensure consistency.